Ok. I pushed the fix to GitHub. I didn't go and make a test for every border case I could think of, but it was passing all the ones I did implement. I ended up finding one other obscure bug in the process. The performance of cpSpaceRemoveShape() should still be ok, though I did have to add the linear search of the cached arbiter set back. Oh well, at least the implementation is a lot simpler... and correct.
The performance fix added in Chipmunk 6 for adding/removing static shapes didn't need to change at all. So that's still there.
Changes in sensor behavior in Chipmunk 6
- slembcke
- Site Admin
- Posts: 4166
- Joined: Tue Aug 14, 2007 7:13 pm
- Contact:
Re: Changes in sensor behavior in Chipmunk 6
Can't sleep... Chipmunks will eat me...
Check out our latest projects! -> http://howlingmoonsoftware.com/wordpress/
Check out our latest projects! -> http://howlingmoonsoftware.com/wordpress/
-
- Posts: 28
- Joined: Tue Jul 12, 2011 6:31 am
- Contact:
Re: Changes in sensor behavior in Chipmunk 6
Thanks! I'm in the middle of some tentacle rendering code, but I'll update tomorrow most likely. Thank you again!
-
- Posts: 28
- Joined: Tue Jul 12, 2011 6:31 am
- Contact:
Re: Changes in sensor behavior in Chipmunk 6
Hey, it work beautifully. Thanks for fixing it!
- slembcke
- Site Admin
- Posts: 4166
- Joined: Tue Aug 14, 2007 7:13 pm
- Contact:
Re: Changes in sensor behavior in Chipmunk 6
When I saw this thread had a new post, my first thought was "I really hope he didn't find a new bug in one of the cases I didn't write unit tests for yet!" Heh
Can't sleep... Chipmunks will eat me...
Check out our latest projects! -> http://howlingmoonsoftware.com/wordpress/
Check out our latest projects! -> http://howlingmoonsoftware.com/wordpress/
Who is online
Users browsing this forum: No registered users and 1 guest